strip \r (if present) before final \n #4329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This sounds like #4319. Could you please look through the comments over there, and then say if this PR is still relevant or not? |
|
So the Node.js version doesn’t matter for you? |
|
I just upgraded to node 6.7.0 and this PR is not required. Perhaps it was a transient thing that only impacted node versions on Mac between 6.4.x and 6.6.x? Having said that, this small fix might help people on those versions and shouldn't hurt anything otherwise. It just just does this: - @written[@written.length - 1 + fromEnd].replace /\n$/, ''
+ @written[@written.length - 1 + fromEnd].replace /\r?\n$/, '' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 'cake test', which was failing due to "\r\n" terminators