[CS2] Spread syntax triple dots on either right or left #4606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
connec
reviewed
Jul 7, 2017
src/rewriter.coffee
Outdated
| if (tag in IMPLICIT_FUNC and token.spaced or | ||
| tag is '?' and i > 0 and not tokens[i - 1].spaced) and | ||
| (nextTag in IMPLICIT_CALL or | ||
| (nextTag in [IMPLICIT_CALL..., '...'] or |
There was a problem hiding this comment.
Bit of a nitpick but... this could be nextTag in IMPLICIT_CALL or nextTag is '...' and would probably be a bit cheaper and, I think, more readable (assuming we can't simply add ... to IMPLICIT_CALL).
There was a problem hiding this comment.
Hmmm, looks like it’s much cheaper: https://jsperf.com/in-spread-array-vs-two-comparisons/1
|
I'm still not entirely convinced it's a good idea 😛 but apart from a small nitpick it LGTM. What's our strategy going to be for documenting this? |
Tiny note in the changelog, and nothing else 😉 |
GeoffreyBooth
changed the title
This was referenced Jul 28, 2017
This was referenced Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #85.
{a, b, r...} = {a:1, b:2} {a, b, ...r} = {a:1, b:2} o = {obj1..., a:1, ...obj2} a = [a, b, arr1..., c, d, ...arr2] f args... f ...args ({a, r...}) -> ({a, ...r}) ->