Fix #4780: Babel should get correct options #4785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d transpiling, so that options are correct on subsequent iterations
connec
reviewed
Nov 13, 2017
| @@ -140,12 +140,14 @@ exports.compile = compile = withPrettyErrors (code, options = {}) -> | |||
| transpiler = options.transpile.transpile | |||
| delete options.transpile.transpile | |||
|
|
|||
| transpilerOptions = Object.assign {}, options.transpile | |||
There was a problem hiding this comment.
Could be a good opportunity for some objects spreads 😄
transpilerOptions = { options.transpile... }There was a problem hiding this comment.
Yeah, indeed. 😄 I’m avoiding using them in the codebase, though, because the compiler is supposed to stay compatible with Node 6 and at some point that syntax will reach Stage 4 and we’ll start outputting it as is.
There was a problem hiding this comment.
Any other notes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4780. Currently when compiling with
--transpile, the options object being sent to Babel isn’t “clean”—it’s a mutated version of the same options object for each iteration of the loop of each file that’s being compiled. So in #4780 the result of this was that some of the fields of source maps.mapfiles were the same values for all files, when they shouldn’t be. This PR fixes things so that theoptionsobject is never mutated, but rather if we need to make adjustments to the options we pass to Babel, those adjustments happen in a copy.@lydell you would be proud.