simplified test file skiping (#4996) #4998
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You don't need to worry about your Git history. We squash commits when we merge into |
|
whoops. That extra commit was a no-op. I was trying to clean up my fork of the repo. Sorry for the distraction. |
|
Did you mean to close this pull request? I think deleting your branch closed it automatically. |
|
I did not mean to. Weird. I decided to help out in order to learn, but this wasn't what I had in mind. :) It won't let me re-open since I deleted the branch, so I'll create a THIRD PR... Derp derp.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-creation of PR #4997 without the extraneous history. Original description follows.
Per discussion on #4893, managing exclusion of tests when newer features are required is currently non-obvious. The goal of this PR is to make maintenance of such exceptions easy and surprise-free.
The existing method was a hard-wired exception for the file 'async.coffee'. When I added async_iterators for #4893 I was surprised because I didn't know about the
build:watch:harmonybuild target nor the hardwired exception in runTests. Now both the feature test and filename match are handled on the same lines near the top of Cakefile.I included two currently unused pattern/feature pairs to demonstrate the intent and value of this approach. Both will likely be used for #4877 and #4893.
I didn't write a test for this change since it's a change to the test system.
After posting this I'm going to figure out how to remove the extra unrelated empty commits, but I wanted to get this out there before the weekend to follow through on my previous commitment.