Skip to content

Feature test directories (alternative to PR 5003) #5007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

rdeforest
Copy link
Contributor

@rdeforest rdeforest commented Mar 6, 2018

This is an alternative to #5003 for making some tests not run (or even compile) when the runtime doesn't support a feature they rely on.

This change removes the need to edit Cakefile whenever tests are added for which rely on a feature not previously relied on. The tests need only be placed in a directory containing an index.coffee which tests for the feature they require.

The following pending PRs would benefit from this:

@GeoffreyBooth
Copy link
Collaborator

I think I would prefer #5003. I think that over time we will increase the minimum version of Node required; Node 6 reaches end-of-life in April 2019, for example, and so that would seem to be the time to drop support for it (if not sooner) and the number of “exceptions” will simplify each time we do so. Also the folder-based approach lacks flexibility when it comes to extending the selective loading to the browser tests; presumably different files would be loaded for testing in browsers, or even testing in different browsers.

@GeoffreyBooth
Copy link
Collaborator

P.S. I don’t mean my closing this to be the final say on the matter. I’m happy to reopen if the other maintainers feel that this is the better of the two PRs. Just trying to de-clutter.

@rdeforest rdeforest deleted the feature-test-directories branch March 18, 2018 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants