-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Added 'SetupDiOpenDevRegKey' and 'SetupDiEnumDeviceInfo' to SetupApi. #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 'SetupDiOpenDevRegKey' and 'SetupDiEnumDeviceInfo' to SetupApi. #419
Conversation
boolean hasNoMoreItems = (getLastError() == ERROR_NO_MORE_ITEMS); | ||
|
||
assertTrue(succeed || hasNoMoreItems); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much space! Please cleanup.
Thanks. Take a look at the diff on Github, you have a problem with CR/LF vs. LF/CR it looks like, the diff should look clean here. Same with tabs vs. spaces. I know it's annoying, but we want history to look readable. Once that's fixed, please squash these commits - lmk if you need any help. |
I am unable to solve the CR/LF vs LF/CR issue, i reverted the CHANGES.md to the version of the last commit before my change but it still doesn't change back and shows diffs. In my Eclipse diff i dont see that at all, only my added line. |
Actually revert it and edit it with something else than Eclipse? I am not sure what to do, but I can merge this manually later. |
Yes i tried to revert it and change it in Notepad++, no luck. I can't even revert the CHANGES.md, the diffs are shown her in github, maybe this a github-bug? |
Definitely not a Github bug :) |
Okay i have no luck with this CRLF LFCR issue. I tried other editors, Can you please add this to the CHANGES.md -> Out of interest, what delimiter is currently used for the CHANGES.md?
|
constants to `com.sun.jna.platform.win32.SetupApi`
Looks like you fixed it! What did you do? Care to add to the https://github.com/twall/jna/blob/master/www/WindowsDevelopmentEnvironment.md docs? |
Merged via 0b47d1e. Thanks for hanging in here! |
I used the secret magic of the mighty -> github-file-editor ;-) |
Added the methods 'SetupDiOpenDevRegKey' and 'SetupDiEnumDeviceInfo' and constants associated with it to the SetupApi.
NOTE: this pull request is a replacement for #335 since i failed to rebase it.