Added XFetchName to X11 interface.
#484
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@twall I believe I did the |
|
This needs a test, please. And squash your commits. |
|
@pinaf Yes, that is how the "return" of a pointer should be mapped. You should be able to add a test for this, even if it's only to look up a nonexistent name. |
|
Changes have been applied, though github seems a bit confused about it. |
mstyura
pushed a commit
to mstyura/jna
that referenced
this pull request
Sep 9, 2024
…ram size (java-native-access#484) Motivation: We used a hardcoded value for the maximum datagram packet size before. This is problematic for two reasons, first off if the remote peer uses a smaller MTU it might never receive a packet. Secondly it might also affect performance in a negative way. Modifications: - Use quiche_conn_max_send_udp_payload_size(...) to obtain the maximum datagram payload size. Result: No risk of packet loss due small MTU and also better performance if remote peer supports large datagrams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XFetchNametoX11interface.used https://tronche.com/gui/x/xlib/ICC/client-to-window-manager/XFetchName.html as reference