Skip to content

Fix issue 3387 LexicalPreservingPrinter adds wrong indentation when adding new comments #3392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2021

Conversation

jlerbsc
Copy link
Collaborator

@jlerbsc jlerbsc commented Oct 5, 2021

Fixes #3387 .

LexicalPreservingPrinter adds wrong indentation when adding new comments
LexicalPreservingPrinter adds wrong indentation when adding new comments
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #3392 (13b29f8) into master (1eeae2c) will increase coverage by 0.000%.
The diff coverage is 66.666%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master     #3392   +/-   ##
===========================================
  Coverage     57.384%   57.385%           
  Complexity      2611      2611           
===========================================
  Files            624       624           
  Lines          34389     34394    +5     
  Branches        5817      5819    +2     
===========================================
+ Hits           19734     19737    +3     
- Misses         12685     12686    +1     
- Partials        1970      1971    +1     
Flag Coverage Δ
AlsoSlowTests 57.385% <66.666%> (+<0.001%) ⬆️
javaparser-core 52.990% <66.666%> (+0.001%) ⬆️
javaparser-symbol-solver 35.497% <0.000%> (-0.006%) ⬇️
jdk-10 57.377% <66.666%> (+<0.001%) ⬆️
jdk-11 57.377% <66.666%> (+<0.001%) ⬆️
jdk-12 57.377% <66.666%> (+0.006%) ⬆️
jdk-13 57.377% <66.666%> (+<0.001%) ⬆️
jdk-14 57.377% <66.666%> (+<0.001%) ⬆️
jdk-15 57.377% <66.666%> (+<0.001%) ⬆️
jdk-16 57.377% <66.666%> (+0.006%) ⬆️
jdk-8 57.382% <66.666%> (+<0.001%) ⬆️
jdk-9 57.377% <66.666%> (+<0.001%) ⬆️
macos-latest 57.382% <66.666%> (+<0.001%) ⬆️
ubuntu-latest 57.376% <66.666%> (+<0.001%) ⬆️
windows-latest 57.382% <66.666%> (+<0.001%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../lexicalpreservation/LexicalPreservingPrinter.java 73.475% <66.666%> (-0.209%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eeae2c...13b29f8. Read the comment docs.

@MysterAitch MysterAitch added the PR: Fixed A PR that offers a fix or correction label Oct 5, 2021
@jlerbsc jlerbsc merged commit 8cf73af into javaparser:master Oct 5, 2021
@MysterAitch MysterAitch added this to the next release milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Fixed A PR that offers a fix or correction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LexicalPreservingPrinter adds wrong indentation when adding new comments
2 participants