Skip to content

Fix: issue 4554 Import added through CompilationUnit.addImport should not have a range #4693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 10, 2025

Conversation

jlerbsc
Copy link
Collaborator

@jlerbsc jlerbsc commented Mar 10, 2025

Fixes #4554 .

jlerbsc added 2 commits March 10, 2025 21:59
… not have a range
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.198%. Comparing base (a93cd4d) to head (fc7d6a6).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...a/com/github/javaparser/ast/ImportDeclaration.java 77.777% 0 Missing and 2 partials ⚠️
...main/java/com/github/javaparser/ast/expr/Name.java 0.000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##              master     #4693       +/-   ##
===============================================
- Coverage     58.204%   58.198%   -0.006%     
  Complexity      2497      2497               
===============================================
  Files            670       670               
  Lines          38717     38719        +2     
  Branches        7023      7022        -1     
===============================================
- Hits           22535     22534        -1     
- Misses         13292     13293        +1     
- Partials        2890      2892        +2     
Flag Coverage Δ
AlsoSlowTests 58.198% <72.727%> (-0.006%) ⬇️
javaparser-core 58.198% <72.727%> (-0.006%) ⬇️
javaparser-symbol-solver 58.198% <72.727%> (-0.006%) ⬇️
jdk-10 57.757% <72.727%> (-0.006%) ⬇️
jdk-11 57.757% <72.727%> (-0.006%) ⬇️
jdk-12 57.757% <72.727%> (-0.006%) ⬇️
jdk-13 57.757% <72.727%> (-0.006%) ⬇️
jdk-14 57.997% <72.727%> (-0.006%) ⬇️
jdk-15 57.997% <72.727%> (-0.006%) ⬇️
jdk-16 57.971% <72.727%> (-0.006%) ⬇️
jdk-17 58.126% <72.727%> (-0.006%) ⬇️
jdk-18 58.126% <72.727%> (-0.006%) ⬇️
jdk-8 57.758% <72.727%> (-0.006%) ⬇️
jdk-9 57.754% <72.727%> (-0.006%) ⬇️
macos-latest 58.191% <72.727%> (-0.006%) ⬇️
ubuntu-latest 58.185% <72.727%> (-0.006%) ⬇️
windows-latest 58.180% <72.727%> (-0.006%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ava/com/github/javaparser/ast/CompilationUnit.java 74.712% <100.000%> (-0.661%) ⬇️
...va/com/github/javaparser/ast/stmt/SwitchEntry.java 55.769% <ø> (ø)
...main/java/com/github/javaparser/ast/expr/Name.java 61.538% <0.000%> (-1.207%) ⬇️
...a/com/github/javaparser/ast/ImportDeclaration.java 73.076% <77.777%> (+0.349%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ceb3bb...fc7d6a6. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jlerbsc added 2 commits March 10, 2025 23:09
@jlerbsc jlerbsc merged commit fe6856f into javaparser:master Mar 10, 2025
35 checks passed
@jlerbsc jlerbsc added this to the 3.26.4 milestone Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import added through CompilationUnit.addImport should not have a range
1 participant