fixed random search where only one path is explored even with limit > 1 #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cyrille-artho This pull request fixes a bug in RandomSearch implementation. |
|
Thank you very much for finding and fixing this as well as adding a test. |
cyrille-artho
requested changes
Nov 12, 2019
cyrille-artho
approved these changes
Nov 13, 2019
|
Thank you very much! I have merged the two patches into one and merged it. |
|
Happy to help :) |
varad64
pushed a commit
to varad64/jpf-core
that referenced
this pull request
Aug 12, 2023
…explored even with limit > 1
cyrille-artho
pushed a commit
that referenced
this pull request
Aug 12, 2023
…with limit > 1 (#401) Co-authored-by: varad64 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the
RandomSearchalways returns after finishing one path, this PR tries to fix this problem and allow it to explore mutiple paths specified bysearch.RandomSearch.path_limit. The previous code will fail the added test but should pass after merged.Now after
cg.randomize_choicesset to notNONE, the search will randomly try different paths.