Unit test for java.time

[gaurangkudale]

Added the unit test for java.time

[gaurangkudale]

Hi @cyrille-artho,
As you said I've done the changes and created the new pull request please give me your thought on this and I want to work on any javapathfinder project if you have any project available for me please let me know.
I'm really excited and looking forward to do more contribution in JPF and learn new things

[gaurangkudale]

@cyrille-artho
Any updates?

[gaurangkudale]

Hi @cyrille-artho,
Here is a quick update I've added some more easy and simple test cases where java.time package is used waiting for your review

[cyrille-artho]

Thank you for the new tests. They are very good overall, and I think they cover the functionality sufficiently. As long as no native code is invoked, the existing library functions can be used without problems.

There is one place where an assertion is repeated (lines 20, 21); please remove the duplicate. Other than that, the tests look good, and we can include them after that change.

[gaurangkudale]

Hi @cyrille-artho
Changes are done and there is one more thing I want to work on any javapathfinder core project if you have any project available for me please let me know.
I'm really excited and looking forward to do more contributions to JPF and learning new things
Working on a new project will help me to expand my knowledge

[cyrille-artho]

Thanks for your changes. A final question: What do you mean with

//TODO show time difference is either 0 or 60`

If you subtract one timestamp from an identical one, shouldn't the difference always be 0? Unless I'm wrong, the comment can be removed.

[cyrille-artho]

As of new tasks, the most urgent tasks are to ensure that all key features in Java 11 work as they did in Java 8.
There are a couple of unit tests that fail on Java 11, and sometimes, a smaller test can help us narrow down the root cause and develop a fix.

[gaurangkudale]

tract one timesta

Yeah that's Right I'LL remove that comment

[cyrille-artho]

One test fails now:

 java8.ClockTest > switch_clock_time_zone_test FAILED
    java.lang.AssertionError at ClockTest.java:32

You can check the CI build status to get this information, by following the "Details" link next to the red X that marks the failed build.

[gaurangkudale]

Hi@cyrille-artho
can you please review the code now?

[gaurangkudale]

One test fails now:

 java8.ClockTest > switch_clock_time_zone_test FAILED
    java.lang.AssertionError at ClockTest.java:32

You can check the CI build status to get this information, by following the "Details" link next to the red X that marks the failed build.

Actually I'm not familiar with CI
I want to learn CI/CD from can you please guide me from where should I start

[cyrille-artho]

Great, it works now!
You can find a good short intro about CI on YouTube: https://www.youtube.com/watch?v=1er2cjUq1UI