Skip to content

Error handling, "try..catch" #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 13, 2020
Merged

Error handling, "try..catch" #279

merged 11 commits into from
Jul 13, 2020

Conversation

cortizg
Copy link
Contributor

@cortizg cortizg commented Jun 22, 2020

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team June 22, 2020 23:40
@javascript-translate-bot
Copy link

Error: the article already has PR number in the Progress Issue #17, it's 180 ⁉️

@iliakan iliakan mentioned this pull request Jul 7, 2020
Open
joaquinelio
joaquinelio requested changes Jul 7, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos,
conflictos con original,
y unos cuantos delirios que podés ignorar

Reemplac+e # en issue17

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

cortizg and others added 8 commits July 10, 2020 20:48
@cortizg @joaquinelio
Update 1-js/10-error-handling/1-try-catch/article.md
e0612fa 
Co-authored-by: joaquinelio <[email protected]>
@cortizg @joaquinelio
Update 1-js/10-error-handling/1-try-catch/article.md
993537b 
Co-authored-by: joaquinelio <[email protected]>
@cortizg @joaquinelio
Update 1-js/10-error-handling/1-try-catch/article.md
75a3597 
Co-authored-by: joaquinelio <[email protected]>
@cortizg @joaquinelio
Update 1-js/10-error-handling/1-try-catch/article.md
5737753 
Co-authored-by: joaquinelio <[email protected]>
@cortizg @joaquinelio
Update 1-js/10-error-handling/1-try-catch/article.md
efc254a 
Co-authored-by: joaquinelio <[email protected]>
@cortizg @joaquinelio
Update 1-js/10-error-handling/1-try-catch/article.md
2a39610 
Co-authored-by: joaquinelio <[email protected]>
@cortizg @joaquinelio
Update 1-js/10-error-handling/1-try-catch/article.md
791a231 
Co-authored-by: joaquinelio <[email protected]>
@cortizg @joaquinelio
Update 1-js/10-error-handling/1-try-catch/article.md
2b0005a 
Co-authored-by: joaquinelio <[email protected]>
@cortizg
Copy link
Contributor Author

cortizg commented Jul 11, 2020

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team July 11, 2020 02:51
joaquinelio
joaquinelio requested changes Jul 11, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disculpas se me escapó un pequeñisimo err conceptual.
catch binding

Solo eso y pueden mersheár, asuman aprobado.

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@cortizg
Copy link
Contributor Author

cortizg commented Jul 11, 2020

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team July 11, 2020 14:26
joaquinelio
joaquinelio approved these changes Jul 12, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

vplentinax
vplentinax approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@joaquinelio joaquinelio merged commit bd8ad7a into javascript-tutorial:master Jul 13, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes

@vplentinax vplentinax vplentinax approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cortizg @javascript-translate-bot @joaquinelio @vplentinax