Skip to content

Index #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 20, 2020
Merged

Index #306

merged 7 commits into from
Jul 20, 2020

Conversation

maksumi
Copy link
Collaborator

@maksumi maksumi commented Jul 17, 2020

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team July 17, 2020 03:23
joaquinelio
joaquinelio requested changes Jul 17, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medio muerto,
pero ver el indice bien en el server es bueno para la moral

el proyecto avanza...

1-js/05-data-types/index.md Outdated

More data structures and more in-depth study of the types.
Más estructuras de datos y más estudio a fondo de los tipos.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Más estructuras de datos y más estudio a fondo de los tipos.
Más estructuras de datos y un estudio más a fondo de los tipos.

CREO que quiso decir esta vez es mas a fondo, no que antes era a fondo y ahora más de eso.

Tampoco me gusta el original.... "más" me parece ocioso.
como quieras

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¿Qué te parece "un estudio más profundo"? @joaquinelio

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Maksumi Murakami and others added 3 commits July 17, 2020 01:33
@maksumi
Copy link
Collaborator Author

maksumi commented Jul 17, 2020

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team July 17, 2020 06:56
@maksumi maksumi requested review from joaquinelio and removed request for a team July 17, 2020 07:03
@maksumi
Copy link
Collaborator Author

maksumi commented Jul 18, 2020

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team July 18, 2020 16:38
@maksumi
Copy link
Collaborator Author

maksumi commented Jul 18, 2020

/done

vplentinax
vplentinax approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Listo calisto!

@joaquinelio joaquinelio merged commit a5f8b88 into javascript-tutorial:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes

@vplentinax vplentinax vplentinax approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maksumi @javascript-translate-bot @joaquinelio @vplentinax