-
Notifications
You must be signed in to change notification settings - Fork 228
Objects #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Objects #321
Changes from 27 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
0189e27
Merge pull request #1 from javascript-tutorial/master
e96e72c
Merge pull request #2 from javascript-tutorial/master
96d99aa
Update
f152057
Update
42f7cc6
Update
a17a435
Update
f17b890
Update
0db6fe7
Update
c3aee22
Update
22a88dc
Update
5228b7e
Update 1-js/04-object-basics/01-object/2-hello-object/task.md
41da662
Update task.md
84181ea
Update task.md
6fa85e8
Update solution.md
d5be7a6
Update 1-js/04-object-basics/01-object/8-multiply-numeric/_js.view/so…
a896cac
Update article.md
c69573f
Update article.md
2337f50
Update article.md
98ed40e
Update 1-js/04-object-basics/01-object/article.md
127a18f
Update 1-js/04-object-basics/01-object/article.md
216253d
Update 1-js/04-object-basics/01-object/article.md
ecb9dc2
Update article.md
89c905b
Update 1-js/04-object-basics/01-object/article.md
3965ce2
Update 1-js/04-object-basics/01-object/article.md
bbe7591
Update article.md
87b5292
Update article.md
3070aa6
Update
59c64ae
Update 1-js/04-object-basics/01-object/article.md
5ab2bda
Update 1-js/04-object-basics/01-object/article.md
6ee7129
Update 1-js/04-object-basics/01-object/article.md
07f7321
Update 1-js/04-object-basics/01-object/article.md
2609768
Update 1-js/04-object-basics/01-object/article.md
31ea37c
Update 1-js/04-object-basics/01-object/article.md
0bbfc4a
Apply suggestions from code review
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
1-js/04-object-basics/01-object/3-is-empty/_js.view/solution.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
Just loop over the object and `return false` immediately if there's at least one property. | ||
Solo crea un bucle sobre el objeto y, si hay al menos una propiedad, devuelve `false` inmediatamente. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 3 additions & 4 deletions
7
1-js/04-object-basics/01-object/8-multiply-numeric/_js.view/source.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,16 @@ | ||
let menu = { | ||
width: 200, | ||
height: 300, | ||
title: "My menu" | ||
title: "Mi menú" | ||
}; | ||
|
||
|
||
function multiplyNumeric(obj) { | ||
|
||
/* your code */ | ||
/* tu código */ | ||
|
||
} | ||
|
||
multiplyNumeric(menu); | ||
|
||
alert( "menu width=" + menu.width + " height=" + menu.height + " title=" + menu.title ); | ||
|
||
alert( "ancho del menú=" + menu.width + " alto=" + menu.height + " título=" + menu.title ); |
8 changes: 4 additions & 4 deletions
8
1-js/04-object-basics/01-object/8-multiply-numeric/_js.view/test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.