Skip to content

Object.keys, values, entries #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 10, 2021
Merged

Object.keys, values, entries #137

merged 9 commits into from
Aug 10, 2021

Conversation

mahdiHash
Copy link
Contributor

Please review and comment / commit if anything is wrong

@javascript-translate-bot javascript-translate-bot requested a review from a team August 10, 2021 10:23
@javascript-translate-bot javascript-translate-bot mentioned this pull request Aug 10, 2021
Open
mahdyar
mahdyar requested changes Aug 10, 2021
View reviewed changes
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@mahdiHash @mahdyar
Apply suggestions from code review
568a4f8 
Co-authored-by: Mahdyar Hasanpour <[email protected]>
@mahdiHash
Copy link
Contributor Author

Thank you, @mahdyar
/done

@javascript-translate-bot javascript-translate-bot requested a review from a team August 10, 2021 17:58
mahdyar
mahdyar requested changes Aug 10, 2021
View reviewed changes
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@mahdiHash
Copy link
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team August 10, 2021 19:22
mahdyar
mahdyar approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mahdiHashemi14!

@mahdyar mahdyar merged commit 020a7be into javascript-tutorial:master Aug 10, 2021
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahdyar mahdyar mahdyar approved these changes

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mahdiHash @javascript-translate-bot @mahdyar