-
Notifications
You must be signed in to change notification settings - Fork 98
Decorators and forwarding, call/apply #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Line 62 needs more attention
Also, fixed a typo and line 414 needs a little more attention
I didn't know how to translate "cooldown" in line 7. Your help is appreciated :)
I changed the file a little bit to make it look good for Persian readers No lines are added. The changes are done inline.
The whole translation needs more attention.
Could you consider adding line comments for the next times (or even this time) instead of just writing the lines? It'd be much simpler to review. You can also link to a specific line(s) of code by clicking on it's line number(s) on the left. [+] |
1-js/06-advanced-functions/09-call-apply-decorators/03-debounce/task.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/09-call-apply-decorators/03-debounce/debounce.view/index.html
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/09-call-apply-decorators/04-throttle/_js.view/solution.js
Outdated
Show resolved
Hide resolved
Please make the requested changes. After it, add a comment "/done". |
I'll add line comments next time. |
Co-authored-by: Mahdyar Hasanpour <[email protected]>
And change the word "منعشده" to "معلق"
Thanks for your review @mahdyar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @mahdiHashemi14!
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
Line 62 & 414 of article needs more attention.
I didn't know how to translate "cooldown" in line 7 of task of "debounce". Your help is appreciated :)
I changed the "index.html" file in "debounce" a little bit to make it look good for Persian readers.
No lines are added. The changes are done inline.
And the last but not the least: the whole translation of task of "throttle" needs more attention. It was difficult to translate.
Please review and comment/commit if anything is wrong