Skip to content

Decorators and forwarding, call/apply #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Oct 18, 2021

Conversation

mahdiHash
Copy link
Contributor

Line 62 & 414 of article needs more attention.

I didn't know how to translate "cooldown" in line 7 of task of "debounce". Your help is appreciated :)

I changed the "index.html" file in "debounce" a little bit to make it look good for Persian readers.
No lines are added. The changes are done inline.

And the last but not the least: the whole translation of task of "throttle" needs more attention. It was difficult to translate.

Please review and comment/commit if anything is wrong

@mahdyar
Copy link
Member

mahdyar commented Oct 17, 2021

Line 62 & 414 of article needs more attention.

I didn't know how to translate "cooldown" in line 7 of task of "debounce". Your help is appreciated :)

I changed the "index.html" file in "debounce" a little bit to make it look good for Persian readers. No lines are added. The changes are done inline.

And the last but not the least: the whole translation of task of "throttle" needs more attention. It was difficult to translate.

Please review and comment/commit if anything is wrong

Could you consider adding line comments for the next times (or even this time) instead of just writing the lines? It'd be much simpler to review.

You can also link to a specific line(s) of code by clicking on it's line number(s) on the left. [+]

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@mahdiHash
Copy link
Contributor Author

Line 62 & 414 of article needs more attention.
I didn't know how to translate "cooldown" in line 7 of task of "debounce". Your help is appreciated :)
I changed the "index.html" file in "debounce" a little bit to make it look good for Persian readers. No lines are added. The changes are done inline.
And the last but not the least: the whole translation of task of "throttle" needs more attention. It was difficult to translate.
Please review and comment/commit if anything is wrong

Could you consider adding line comments for the next times (or even this time) instead of just writing the lines? It'd be much simpler to review.

You can also link to a specific line(s) of code by clicking on it's line number(s) on the left. [+]

I'll add line comments next time.

@mahdiHash
Copy link
Contributor Author

Thanks for your review @mahdyar
/done

Copy link
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mahdiHashemi14!

@mahdyar mahdyar merged commit e2e74dc into javascript-tutorial:master Oct 18, 2021
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants