Skip to content

Property getters and setters #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 12, 2021
Merged

Conversation

mahdiHash
Copy link
Contributor

Please review and comment/commit if anything is wrong

The lines 107 to 110 were started from left, because there were English words in the beginning, and they didn't look nice.  
I added Persian words in the beginning, so the lines start from right.
Line 188 needs more attention
@mahdiHash mahdiHash marked this pull request as ready for review November 11, 2021 13:35
Copy link
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the requested changes.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-authored-by: Mahdyar Hasanpour <[email protected]>
Replaced «گیرنده» with "getter"  
Replaced «تنظیم‌کننده» with "setter"  
Replaced «دسترسی» with «اکسسر»  

And some small changes:  
- Fixed a typo in line 203  
- Also changed a word in lines 108 and 143
@mahdiHash
Copy link
Contributor Author

Thank you @mahdyar
/done

@mahdyar mahdyar merged commit 4d2b165 into javascript-tutorial:master Nov 12, 2021
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants