Skip to content

Automated testing with Mocha #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 3, 2023

Conversation

EhsanShahbazii
Copy link
Contributor

/done

@javascript-translate-bot

Error: the article has another translator @mahdyar in the Progress Issue #1.

@CLAassistant
Copy link

CLAassistant commented Jan 2, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mahdiHash
❌ EhsanShahbazii
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@mahdiHash mahdiHash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the changes. Notice the apply-to-whole ones.
You can add the suggestions to a batch and submit a single commit (docs).

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@mahdiHash
Copy link
Contributor

Please translate the tasks, too.

@EhsanShahbazii
Copy link
Contributor Author

ok. I corrected the file.

@EhsanShahbazii
Copy link
Contributor Author

/done

Copy link
Contributor

@mahdiHash mahdiHash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggestions.
You can add the suggestions to a batch and submit a single commit (docs).

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@EhsanShahbazii
Copy link
Contributor Author

/done

Add an extra line to match the LOC of the English article.
@mahdiHash
Copy link
Contributor

Please translate the tasks, too.

Have you translated the tasks, @EhsanShahbazii?

@EhsanShahbazii
Copy link
Contributor Author

EhsanShahbazii commented Jan 2, 2023

The word task in article? yes @mahdiHash

@mahdiHash
Copy link
Contributor

The word task in article? yes @mahdiHash

No, I mean the task here.
You translated them in #249, but not in this PR.

@EhsanShahbazii
Copy link
Contributor Author

i see. done @mahdiHash

@mahdiHash
Copy link
Contributor

Thanks for your contribution, @EhsanShahbazii.

@EhsanShahbazii
Copy link
Contributor Author

EhsanShahbazii commented Jan 2, 2023

Thank you for your explanation and guidance.🤍 @mahdiHash

@mahdiHash mahdiHash merged commit 1f1b759 into javascript-tutorial:master Jan 3, 2023
@javascript-translate-bot

Error: the article has another translator @mahdyar, not @EhsanShahbazii in the Progress Issue #1. Please update the progress issue or ask maintainers to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants