ArrayBuffer, binary arrays #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
还请麻烦您修改一下 PR 内容，写上修改的文件和参考的上游 commit 等 |
KerbalHao
suggested changes
Nov 30, 2019
4-binary/01-arraybuffer-binary-arrays/01-concat/_js.view/solution.js
Outdated
Show resolved
Hide resolved
|
Please make the requested changes. After it, add a comment "/done". |
已修改，谢谢~ /done |
KerbalHao
reviewed
Dec 2, 2019
KerbalHao
reviewed
Dec 2, 2019
|
感谢校对，已修改~ /done |
leviding
requested changes
Dec 4, 2019
There was a problem hiding this comment.
存在几点问题，麻烦译者 @bemself 注意一下，并进行修改：
- 格式细节问题需要仔细
- 翻译成中文的，那就不要用英文的引号来扩中文汉字，符号也要相应改为中文全角
- 空格等细节格式问题
- 168 行的
2<sup>8</sup>是 28，也就是 2 的八次方，不是取余吧？
@KerbalHao 麻烦校对者也注意，在审核翻译的同时，也要审核格式问题。
4-binary/01-arraybuffer-binary-arrays/01-concat/_js.view/solution.js
Outdated
Show resolved
Hide resolved
4-binary/01-arraybuffer-binary-arrays/01-concat/_js.view/solution.js
Outdated
Show resolved
Hide resolved
4-binary/01-arraybuffer-binary-arrays/01-concat/_js.view/source.js
Outdated
Show resolved
Hide resolved
|
Please make the requested changes. After it, add a comment "/done". |
|
麻烦两位 @bemself @KerbalHao 都看下校对意见，现根据校对意见修改一遍，修改的同时需要检查是否还有类似问题，一并修改，辛苦了。 |
resolve review comment Co-Authored-By: LeviDing <[email protected]>
Co-Authored-By: LeviDing <[email protected]>
Co-Authored-By: LeviDing <[email protected]>
Co-Authored-By: LeviDing <[email protected]>
Co-Authored-By: LeviDing <[email protected]>
|
@leviding 感谢校对，已修改~ /done |
leviding
approved these changes
Dec 5, 2019
|
@KerbalHao 感谢校对，已修改。 /done |
|
Error: the article already translated in the Progress Issue #324 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
目标章节：4-binary/01-arraybuffer-binary-arrays
当前上游最新 commit：54984506
所做更改如下：