Skip to content

Translate some chapters to [Jul 17, 2020] Part-6 (#795) #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Sep 21, 2020

Conversation

jtchen2k
Copy link

目标章节: 2-ui

当前上游最新 commit:f38eb4e

本 PR 所做更改如下:

文件名 参考上游 commit 更改(理由)
1-js/05-data-types/02-number/article.md f38eb4e 修复 19 行中 73 亿和 7.2bn 不对应的问题
2-ui/3-event-details/6-pointer-events/article.md f38eb4e 翻译

此外还翻译了 some chapters to [Jul 17, 2020] Part-6 (#795) 中的其他内容。

@CLAassistant
Copy link

CLAassistant commented Jul 22, 2020

CLA assistant check
All committers have signed the CLA.

@leviding leviding mentioned this pull request Jul 23, 2020
4 tasks
@leviding
Copy link
Member

leviding commented Jul 23, 2020

Thanks for your contribution, we will review it.

Related #798

Copy link
Member

@MartinsYong MartinsYong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢翻译,先 review 一部分

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@jtchen2k
Copy link
Author

感谢 Review
/done

Copy link
Member

@MartinsYong MartinsYong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review 其中一部分

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Took some suggestions

Co-authored-by: Martin <[email protected]>
@jtchen2k
Copy link
Author

/done

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@leviding leviding self-assigned this Aug 8, 2020
Commit from suggestion

Co-authored-by: bemself <[email protected]>
@MartinsYong
Copy link
Member

2-ui/3-event-details/6-pointer-events/article.md
第 45 行再看一下
@BillChen2K

@jtchen2k
Copy link
Author

jtchen2k commented Sep 2, 2020

恩恩,已 commit
/done

@MartinsYong
Copy link
Member

MartinsYong commented Sep 5, 2020

不好意思,我这里还有一些可能被你 miss 了
2-ui/1-document/07-modifying-document/article.md 第182 行;
2-ui/3-event-details/1-mouse-events-basics/article.md 第 67 行;
@BillChen2K

已补充 commit。

Co-authored-by: Martin <[email protected]>
@jtchen2k
Copy link
Author

Sorry for the late reply /done

@javascript-translate-bot javascript-translate-bot requested a review from a team September 15, 2020 03:06
Copy link
Member

@leviding leviding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@leviding leviding merged commit f9cb07b into javascript-tutorial:master Sep 21, 2020
@leviding leviding added DONE and removed needs +1 labels Sep 21, 2020
@leviding
Copy link
Member

感谢译者,感谢校对,经过了这么长时间,终于合并了 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants