Skip to content

Upgrade JAX AI Stack for miniGPT doc #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade JAX AI Stack for miniGPT doc #158

wants to merge 1 commit into from

Conversation

8bitmp3
Copy link
Contributor

@8bitmp3 8bitmp3 commented Jan 28, 2025

No description provided.

jakevdp
jakevdp approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@8bitmp3 8bitmp3 force-pushed the update-minigpt branch 2 times, most recently from 058a2a7 to c0737f1 Compare January 31, 2025 23:58
@8bitmp3
Copy link
Contributor Author

8bitmp3 commented Feb 1, 2025

@jakevdp Thanks. Still working on this 👍

@8bitmp3 8bitmp3 marked this pull request as ready for review February 24, 2025 18:50
@8bitmp3
Copy link
Contributor Author

8bitmp3 commented Feb 24, 2025

@jakevdp PTAL

@8bitmp3
Copy link
Contributor Author

8bitmp3 commented Mar 4, 2025

@jakevdp PTAL

1 similar comment
@8bitmp3
Copy link
Contributor Author

8bitmp3 commented Mar 11, 2025

@jakevdp PTAL

@jakevdp jakevdp self-assigned this Mar 17, 2025
@8bitmp3
Copy link
Contributor Author

8bitmp3 commented Mar 17, 2025

TODO: title

@8bitmp3
Copy link
Contributor Author

8bitmp3 commented Apr 10, 2025

@jakevdp ready

@8bitmp3
Copy link
Contributor Author

8bitmp3 commented Apr 11, 2025

@jakevdp PTAL

1 similar comment
@8bitmp3
Copy link
Contributor Author

8bitmp3 commented Apr 14, 2025

@jakevdp PTAL

jakevdp
jakevdp approved these changes Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jakevdp
Copy link
Collaborator

jakevdp commented Apr 15, 2025

Lint is revealing a mismatch between the ipynb and the md. You can fix locally by running pre-commit run --all-files.

@8bitmp3
Copy link
Contributor Author

8bitmp3 commented Apr 16, 2025

@jakevdp on it, thanks for spotting this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakevdp jakevdp jakevdp approved these changes

Assignees

@jakevdp jakevdp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@8bitmp3 @jakevdp