Merge pull request #494 from zakisk/add-pagination-in-pr-list-comments

fix: Add Pagination in Pull Request ListComments on Bitbucket Server …

Author: jenkins-x-bot

scm/driver/stash/pr.go

@@ -100,7 +100,7 @@ func (s *pullService) ListComments(ctx context.Context, repo string, number int,
 
 	projectName, repoName := scm.Split(repo)
 	out := new(pullRequestActivities)
-	path := fmt.Sprintf("rest/api/1.0/projects/%s/repos/%s/pull-requests/%d/activities", projectName, repoName, number)
+	path := fmt.Sprintf("rest/api/1.0/projects/%s/repos/%s/pull-requests/%d/activities?%s", projectName, repoName, number, encodeListOptions(opts))
 	res, err := s.client.do(ctx, "GET", path, nil, out)
 	if !out.pagination.LastPage.Bool {
 		res.Page.First = 1
@@ -501,6 +501,7 @@ func convertPullRequestComment(from *pullRequestComment) *scm.Comment {
 		Created: time.Unix(from.CreatedDate/1000, 0),
 		Updated: time.Unix(from.UpdatedDate/1000, 0),
 		Author: scm.User{
+			ID:     from.Author.ID,
 			Login:  from.Author.Slug,
 			Name:   from.Author.DisplayName,
 			Email:  from.Author.EmailAddress,

scm/driver/stash/testdata/pr_comment.json.golden

@@ -2,6 +2,7 @@
     "ID": 1,
     "Body": "this is a comment",
     "Author": {
+        "ID": 1,
         "Login": "jcitizen",
         "Name": "Jane Citizen",
         "Email": "[email protected]",

scm/driver/stash/testdata/pr_comments.json.golden

@@ -3,6 +3,7 @@
     "ID": 1,
     "Body": "A measured reply.",
     "Author": {
+      "ID": 101,
       "Login": "jcitizen",
       "Name": "Jane Citizen",
       "Email": "[email protected]",