Skip to content

fix: Add Pagination in Pull Request ListComments on Bitbucket Server … #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zakisk
Copy link

@zakisk zakisk commented Mar 27, 2025

…(stash)

on ListComments func in pull request service, pagination query params are not added, this PR add that.

@jenkins-x-bot
Copy link

Hi @zakisk. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@zakisk zakisk force-pushed the add-pagination-in-pr-list-comments branch from 8921e94 to ebda227 Compare March 27, 2025 07:52
@zakisk zakisk force-pushed the add-pagination-in-pr-list-comments branch from ebda227 to eee8697 Compare April 21, 2025 09:45
@zakisk
Copy link
Author

zakisk commented Apr 21, 2025

/assign @msvticket

@zakisk
Copy link
Author

zakisk commented Apr 21, 2025

@msvticket can you please take a look?

@jenkins-x-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msvticket

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zakisk
Copy link
Author

zakisk commented Apr 23, 2025

CI is not running, I think due to needs-ok-to-test label is still there.

@msvticket
Copy link
Member

/ok-to-test

…(stash)

on ListComments func in pull request service, pagination query
params are not added, this PR add that.

Signed-off-by: Zaki Shaikh <[email protected]>
@zakisk zakisk force-pushed the add-pagination-in-pr-list-comments branch from eee8697 to 4048e85 Compare April 23, 2025 06:06
@jenkins-x-bot jenkins-x-bot merged commit cfa3f80 into jenkins-x:main Apr 23, 2025
3 checks passed
@zakisk zakisk deleted the add-pagination-in-pr-list-comments branch April 23, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants