Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade to version 1.23.7 #4138

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/cdf/tekton-pipeline/defaults.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
gitUrl: https://github.com/cdfoundation/tekton-helm-chart
namespace: tekton-pipelines
version: 1.0.2
version: 1.0.5
2 changes: 1 addition & 1 deletion charts/jxgh/lighthouse/defaults.yaml
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
gitUrl: https://github.com/jenkins-x/lighthouse
version: 1.23.4
version: 1.23.7
31 changes: 31 additions & 0 deletions release-notes/tekton-v1.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# Upgrade of API version for Tekton Pipelines to v1

With this upgrade the API version of Tekton Pipeline resources (like pipeline runs) are updated from tekton.dev/v1beta1
to tekton.dev/v1.

If the Kubernetes cluster you now upgrade does not have Tekton Pipelines installed this will naturally not have any
effect. A typical case if this is a remote cluster.

## Potential problems with conversion

In the Jenkins X cluster upgrade process any changes to custom resource definitions are applied first. In this case
this will trigger the Kubernetes cluster to ask tekton-pipelines-webhook to convert existing tekton pipeline
resources in the cluster. At this time the tekton-pipelines-webhook deployment is an old version which include bugs
that can cause old pipeline runs to start executing again. This can cause confusion, especially if a release pipeline
for an old version of an application is run again.

The simplest way to avoid this is to manually delete existing pipeline runs before doing this upgrade. This can be
done by running

```
kubectl delete piplinerun --all -namespace jx
```

## Existing pipelines in application repositories

So far the supported API version of the pipelines in the .ligthouse directory of your application respositories have
been tekton.dev/v1beta1. From now on tekton.dev/v1 is also supported. Any pipelines with version tekton.dev/v1beta1
will be automatically converted to tekton.dev/v1 when read by lighthouse. After the Tekton Pipelines project remove
support for this conversion it will be removed from lighthouse as well. But before that tools to convert the
pipelines in .lighthouse will be made available.