Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a special case for emphasis in line charts #387

Merged
merged 2 commits into from
Apr 11, 2025
Merged

Add a special case for emphasis in line charts #387

merged 2 commits into from
Apr 11, 2025

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Feb 27, 2025

Line charts should disable the emphasis, it makes no sense there.

@uhafner uhafner added the enhancement Enhancement of existing functionality label Feb 27, 2025
# Conflicts:
#	src/main/webapp/js/echarts-api.js
Copy link

☀️   Quality Monitor

Tests

   JUnit   Unit Tests: No test results available
   🚀   Integration tests: 100% successful (15 passed)
   ⛔   Architecture tests: No test results available

Code Coverage

   〰️   Line Coverage: 50% (53 missed lines)
   ➰   Branch Coverage: 50% (6 missed branches)

Style

   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings

Bugs

   SpotBugs   SpotBugs: No bugs

Vulnerabilities

   OWASP Dependency Check   OWASP Dependency Check: 172 vulnerabilities (error: 15, high: 45, normal: 108, low: 4)

Software Metrics

   🌀   Cyclomatic Complexity: 51 (total)
   💭   Cognitive Complexity: 7 (total)
   ➿   N-Path Complexity: 49 (total)
   📏   Lines of Code: 662 (total)
   📝   Non Commenting Source Statements: 156 (total)
   🔗   Class Cohesion: 100.00% (maximum)
   ⚖️   Weight of Class: 100.00% (maximum)


🚧   Error Messages

Quality Monitor Errors:
No matching report files found when using pattern '**/target/surefire-reports/TEST*util*.xml'! Configuration error for 'Unit Tests'?
No matching report files found when using pattern '**/target/surefire-reports/TEST*archunit*.xml'! Configuration error for 'Architecture tests'?

Created by Quality Monitor v2.5.3 (#8fa0834). More details are shown in the GitHub Checks Result.

@uhafner uhafner merged commit a3c08f6 into main Apr 11, 2025
31 checks passed
@uhafner uhafner deleted the color-inherit branch April 11, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant