Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DefaultCredentialsStore javadoc #10470

Merged
merged 4 commits into from
Apr 2, 2025

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Mar 26, 2025

cf. #10235 (comment)

Amends #10235

Testing done

mvn -am -pl war,bom -Pquick-build clean install
mvn javadoc:javadoc

Proposed changelog entries

  • N/A

Proposed changelog category

/label skip-changelog

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@Vlatombe Vlatombe added the documentation Improvements or additions to documentation label Mar 26, 2025
@Vlatombe Vlatombe changed the title Fix javadoc Fix DefaultCredentialsStore javadoc Mar 26, 2025
@Vlatombe Vlatombe added the developer Changes which impact plugin developers label Mar 26, 2025
@timja timja removed the developer Changes which impact plugin developers label Mar 26, 2025
@comment-ops-bot comment-ops-bot bot added the skip-changelog Should not be shown in the changelog label Mar 26, 2025
@timja
Copy link
Member

timja commented Mar 26, 2025

/label ready-for-merge


This PR is now ready for merge, after the upcoming security release, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 26, 2025
Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The checkstyle warning fails the build and reports that the line is
longer than 240 characters.  Break the line on the sentence boundary
so that it is less than 240 characters.

Detected by running:

mvn -am -pl war,bom -Pquick-build clean install
mvn javadoc:javadoc
Co-authored-by: Jesse Glick <[email protected]>
@gbhat618
Copy link
Contributor

The failing test here DirectoryBrowserSupportTest.tmpNotListed likely a flake, it goes to the workspace page

String text = j.createWebClient().goTo("job/" + p.getName() + "/ws/").asNormalizedText();

Noticed issues going to /ws page in other tests too, tried reproduce here #10471 (comment)

@krisstern krisstern merged commit 6988bc2 into jenkinsci:master Apr 2, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants