-
-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'No plugins' notice to Appearance configuration page #10478
Open
janfaracik
wants to merge
3
commits into
jenkinsci:master
Choose a base branch
from
janfaracik:update-appearance-page
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+54
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
reviewed
Mar 28, 2025
<j:set var="instance" value="${it}" /> | ||
<j:set var="descriptor" value="${instance.descriptor}" /> | ||
<j:choose> | ||
<j:when test="${!hasPlugins}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
timja
reviewed
Mar 28, 2025
core/src/main/resources/jenkins/appearance/AppearanceGlobalConfiguration/index.jelly
Show resolved
Hide resolved
6 tasks
timja
approved these changes
Mar 28, 2025
@jenkinsci/sig-ux small one if someone could review please |
@krisstern mind having a quick look? this is blocking the custom header PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing some debugging yesterday with @timja we came across a rather odd issue where on #10245 the Manage Jenkins page would load really slowly, but only when the user was signed in. After a bit of fiddling we roughly identified the issue as something being locked when doing a lookup for
Extension
s as well as for a user'sgetTransientActions
andgetPropertyActions
. Would need to do a bit more digging to figure out why.This is a workaround to the issue, but also improves the user experience a little by not hiding the appearance link when there isn't anything to configure - we instead show a friendly message.
When there are no plugins installed
If anybody has any better ideas for content for this let me know.
Added a little button to the page to get more plugins
Testing done
Proposed changelog entries
Proposed changelog category
/label web-ui,rfe
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@jenkinsci/sig-ux @timja
Before the changes are marked as
ready-for-merge
:Maintainer checklist
upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).