Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'No plugins' notice to Appearance configuration page #10478

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Mar 28, 2025

Doing some debugging yesterday with @timja we came across a rather odd issue where on #10245 the Manage Jenkins page would load really slowly, but only when the user was signed in. After a bit of fiddling we roughly identified the issue as something being locked when doing a lookup for Extensions as well as for a user's getTransientActions and getPropertyActions. Would need to do a bit more digging to figure out why.

This is a workaround to the issue, but also improves the user experience a little by not hiding the appearance link when there isn't anything to configure - we instead show a friendly message.

When there are no plugins installed

If anybody has any better ideas for content for this let me know.

image

Added a little button to the page to get more plugins

image

Testing done

  • Message shows when there are no plugins installed
  • Message hides when there are plugins installed

Proposed changelog entries

  • Add 'No plugins' notice to Appearance configuration page

Proposed changelog category

/label web-ui,rfe

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux @timja

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@comment-ops-bot comment-ops-bot bot added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Mar 28, 2025
@janfaracik janfaracik requested a review from a team March 28, 2025 08:00
<j:set var="instance" value="${it}" />
<j:set var="descriptor" value="${instance.descriptor}" />
<j:choose>
<j:when test="${!hasPlugins}">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably update the user profile page as well to be consistent.

It currently looks like this:

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot - updated it + hid the save/apply buttons.

image

@timja timja requested review from a team and krisstern March 28, 2025 21:50
@timja
Copy link
Member

timja commented Apr 1, 2025

@jenkinsci/sig-ux small one if someone could review please

@timja
Copy link
Member

timja commented Apr 2, 2025

@krisstern mind having a quick look? this is blocking the custom header PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants