support Docker Host Certificate Authentication type

[haoshuwei]

Currently the kubernetes plugin does not support to list and use a credential type of Docker Host Certificate Authentication.This PR will enable this . Please help check that if it is allowed to be merged. Thanks

Signed-off-by: Shuwei Hao [email protected]

[Vlatombe]

It seems wrong to me to introduce a dependency on docker-commons.

Have you tried using the Certificate kind for credentials ? AFAIU it should cover the same use case.

[haoshuwei]

It seems wrong to me to introduce a dependency on docker-commons.

Have you tried using the Certificate kind for credentials ? AFAIU it should cover the same use case.

Yeah, I have tried the Certificate kind for credentials, but it is more convenient to use Docker Host Certificate Authentication type because users can directly get the Client Key Client Certificate or Server CA Certificate content from a kubeconfig file, so I think we should support that type.

[Vlatombe]

I understand the intent, but I feel uneasy pulling something that is labeled as docker specific into Kubernetes.

I would propose to retrofit DockerServerCredentials (and related classes) into credentials-plugin so that it can be used where it is needed.

@stephenc @carlossg any opinions on this topic?

[haoshuwei]

I understand the intent, but I feel uneasy pulling something that is labeled as docker specific into Kubernetes.

I would propose to retrofit DockerServerCredentials (and related classes) into credentials-plugin so that it can be used where it is needed.

@stephenc @carlossg any opinions on this topic?

I agree, if the proposal to retrofit credentials-plugin is suitable. i can also help do this

[stephenc]

I would propose to retrofit DockerServerCredentials (and related classes) into credentials-plugin so that it can be used where it is needed.

No thank you. Put them in a docker-credentials plugin and let everyone who needs them depend on that

[Vlatombe]

Ok, so this is good. I would like the labeling for this kind of credentials to be modified (in docker-commons) in order to remove 'Docker' mention, since this is not specific to Docker actually.