RFC: Add a way to get last queue number and pass the relative url #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allow us to evaluate to change the popup and add the full url to next job Signed-off-by: Michael Trimarchi <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -56,19 +61,37 @@ | |||
| */ | |||
| @RequirePOST | |||
| @JavaScriptMethod | |||
| public boolean doRebuild() throws IOException, ExecutionException { | |||
| public JSONObject doRebuild() throws IOException, ExecutionException, Exception { | |||
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check Warning
timja
reviewed
Feb 6, 2025
| } | ||
| return true; | ||
|
|
||
| QueueTaskFuture<? extends Run<?, ?>> f = (QueueTaskFuture) item.getFuture(); |
There was a problem hiding this comment.
can you have a look at how blue ocean does it please?
I don't think we want a thread waiting for start.
A better way is probably to poll in the frontend for a bit?
There was a problem hiding this comment.
@timja Yes I will do it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch try understand to find a way to calculate the next job and then show a popup to the user include
it to let him to decide to switch to the queue build
It's important to evaluate it and propose change. Right now I have some limited idea how to create
nicer popup