Skip to content

Revamp the Pipeline Console view #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 84 commits into
base: main
Choose a base branch
from

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Apr 9, 2025

image image

This PR revamps the console view for the plugin.

What's new

  • New design
    • Infinite scrolling - no longer do the individual cards scroll, instead the entire page can become one continuous log
    • Sticky sidebar
    • More compact details pane
    • Refined scroll to top/bottom component
  • Moved to function components
  • Removed Material UI design components
  • Simplified codebase

TODO

  • Fix icons in dropdown menu
  • Open dropdown menu links in new tab, make download link work
  • Get stick to bottom working
  • Validate the changes haven't broken anything
  • Validate tests are working + and work as they should
  • Tidy up code

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

let polling = true;

const poll = async () => {
while (polling) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could swap this to websockets as an alternative too

@timja
Copy link
Member

timja commented Apr 13, 2025

I can't seem to find the new scroll to top button?

(GitHub PR diff view is falling over for me now at this size of PR 😢)

@janfaracik
Copy link
Contributor Author

janfaracik commented Apr 13, 2025

I can't seem to find the new scroll to top button?

Open a few steps, it'll pop up in the bottom right. File is ScrollToTopBottom.tsx

(GitHub PR diff view is falling over for me now at this size of PR 😢)

I got a little carried away playing with React Scan and things kinda ballooned.

@janfaracik janfaracik changed the title Revamp the stage view Revamp the Pipeline Console view Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants