Skip to content

Add printing out debug logs using external output #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2018
Merged

Add printing out debug logs using external output #1439

merged 1 commit into from
Jan 25, 2018

Conversation

daeyeon
Copy link
Member

@daeyeon daeyeon commented Jan 24, 2018

IoT.js-DCO-1.0-Signed-off-by: Daeyeon Jeong [email protected]

@daeyeon
Add printing out debug logs using external output
9c7d795 
IoT.js-DCO-1.0-Signed-off-by: Daeyeon Jeong [email protected]
@daeyeon
Copy link
Member Author

daeyeon commented Jan 24, 2018

I made a different approach discussed from #1424. In the context, we assume iotjs_debuglog.c will be renamed to iotjs_logger.c in another commit, which is used both release and debug mode. A console output in iotjs_logger is accessible with iotjs modules and logger itself directly through a global variable.

glistening
glistening approved these changes Jan 24, 2018
View reviewed changes
Copy link
Contributor

@glistening glistening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LaszloLango
LaszloLango approved these changes Jan 24, 2018
View reviewed changes
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaszloLango LaszloLango merged commit c6e391e into jerryscript-project:master Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaszloLango LaszloLango LaszloLango approved these changes

@glistening glistening glistening approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daeyeon @LaszloLango @glistening