Disable the debug popup on win32/msvc.

[lygstate]

For not popup dialog when crash happend on MSVC/win32
related issue: #4463

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo [email protected]

[akosthekiss]

I'm not completely sure that console apps should be tweaked just because Windows doesn't let them crash without displaying graphical UI elements. Isn't it easier to simply disable that service on Windows? https://docs.microsoft.com/en-us/powershell/module/windowserrorreporting/disable-windowserrorreporting?view=win10-ps

[rerobika]

I'd second @akosthekiss's suggestion and I can agree that it must not be implemented in the console app.

[ossy-szeged]

Is it possible to disable these popup by runner script somehow? If we would like to run Windows testing ever on the CI, we will need to solve this issue somehow.

[akosthekiss]

@ossy-szeged I've suggested (or rather requested feedback on) an approach but haven't heard back since.

[lygstate]

@ossy-szeged I've suggested (or rather requested feedback on) an approach but haven't heard back since.

disable service will affect other applicationsuch as UI

[akosthekiss]

@lygstate You are free to re-enable the service after the execution of the automated tests.

[lygstate]

@lygstate You are free to re-enable the service after the execution of the automated tests.

Yeap, but it's a budren,

[ossy-szeged]

@lygstate You are free to re-enable the service after the execution of the automated tests.

Yeap, but it's a budren,

+1 for @akosthekiss's suggestion. It's not a burden to modify the test runner script to disable the
service before testing and enable the service after testing. It's obviously a testing feature/issue that's
why we don't want to modify jerry console application, but modify the testing script to reach your goal.

[akosthekiss]

@lygstate You are free to re-enable the service after the execution of the automated tests.

Yeap, but it's a budren,

Well, it can be scripted, I guess. Then it is less of a burden. And I definitely prefer the "scripting burden" over cluttering code with Windows-specific debug-popup-blocking magic only because Windows effectively blocks automated testing.

[lygstate]

@lygstate You are free to re-enable the service after the execution of the automated tests.

Yeap, but it's a budren,

Well, it can be scripted, I guess. Then it is less of a burden. And I definitely prefer the "scripting burden" over cluttering code with Windows-specific debug-popup-blocking magic only because Windows effectively blocks automated testing.

No sure if have such a script, there code is also references to other implementation. I'l stick this locally as it works for me