Fix decimal isnumeric #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ases were added in pandas/tests/test_strings.py
rhshadrach
suggested changes
Feb 17, 2025
Comment on lines
+471
to
+481
| def is_numeric(value): | ||
| if value.isnumeric(): | ||
| return True | ||
| else: | ||
| try: | ||
| float(value) # Try converting to float (supports negative and decimals) | ||
| return True | ||
| except ValueError: | ||
| return False | ||
|
|
||
| return self._str_map(is_numeric, dtype="bool") |
There was a problem hiding this comment.
I am negative on this change. As mentioned in the issue, I do not believe we should be changing the behavior of is_numeric here.
There was a problem hiding this comment.
I didn't realize this was a PR in your fork - apologies. However, if you do want to contribute to pandas, you need to open up a PR in the pandas repository and not your fork of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pd.Series.isnumeric()doesn't work on decimal value strings pandas-dev/pandas#60750isnumericnow works to include decimal strings to be evaluated as true.