Use RawIntoIter instead of RawTable + RawIter #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes both #1 and #2 by taking advantage of rust-lang/hashbrown#167. It won't work until that PR is merged, and also requires an implementation of `Clone` for `RawIntoIter`.
Now that rust-lang/hashbrown#171 was merged.
It turns out that with `i8` keys, it is decently likely that you will _accidentally_ have your key be equal to a random byte of memory in uninitialized memory. This was fixed in rust-lang/hashbrown@6010db6
This was referenced Jul 1, 2020
|
Replaced by #12. |
jonhoo
added a commit
that referenced
this pull request
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on rust-lang/hashbrown#167.
Fixes #1.
Fixes #2.