Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added render_stateful_widget method to ScrollView #65

Merged
merged 2 commits into from
Mar 16, 2025

Conversation

netbit
Copy link
Contributor

@netbit netbit commented Mar 13, 2025

The render_stateful_widget method has been added to ScrollView, allowing ScrollView to work with a stateful widget.

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.65%. Comparing base (a93c437) to head (09b65b1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   71.43%   71.65%   +0.21%     
==========================================
  Files          16       16              
  Lines        2626     2635       +9     
==========================================
+ Hits         1876     1888      +12     
+ Misses        750      747       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Owner

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM generally. Would you mind adding a single simple test for this at the end of the unit tests in this file?

Perhaps render a list with 10 items inside a scrollview that is 5 high?

@joshka
Copy link
Owner

joshka commented Mar 15, 2025

LGTM. Thanks for the PR. Will merge once ci runs.

@joshka joshka merged commit cddffc0 into joshka:main Mar 16, 2025
10 of 11 checks passed
@joshka
Copy link
Owner

joshka commented Mar 16, 2025

The broken checks were unrelated to this PR (another crate uses f64::midpoint which was stabilized in rust 1.85, and the current MSRV of the crate is 1.80)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants