Skip to content

WIP TEST #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

WIP TEST #7

wants to merge 2 commits into from

Conversation

mgol
Copy link
Member

@mgol mgol commented Feb 14, 2025

No description provided.

@timmywil
Copy link
Member

timmywil commented Feb 14, 2025

The jquery submodule committed here reverts the changes to the package.json to use local jtr. If you base your broken test commit off jquery's jtr-test branch, the reporter changes should show up.

@mgol mgol force-pushed the globals-broken-test branch from 726e6d6 to 88972b6 Compare February 14, 2025 16:00
@mgol
Copy link
Member Author

mgol commented Feb 14, 2025

OK, I see the error now: https://github.com/jquery/jquery-test-runner/actions/runs/13332833160/job/37240945788?pr=7#step:6:97

I wonder if there was a way to apply this change without keeping some artificial branches on all jtr-using repos. Maybe test scripts could update the package.json in the test repos and then run tests? Of course, that would leave a dirty repository state unless we make sure to apply proper cleanup, but it'd save us from maintaining those jtr-test branches.

@timmywil
Copy link
Member

I wasn't planning on updating those jtr-test branches very often, so it shouldn't require much maintenance. IMO, tests like this using draft PRs and running in CI is unnecessary. You can accomplish all of this locally.

@mgol mgol closed this Feb 14, 2025
@mgol mgol deleted the globals-broken-test branch February 14, 2025 20:30
@mgol
Copy link
Member Author

mgol commented Feb 14, 2025

IMO, tests like this using draft PRs and running in CI is unnecessary. You can accomplish all of this locally.

That's true, it's much easier this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants