Skip to content

Slider: Add demo for custom handle #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Slider: Add demo for custom handle #1740

wants to merge 2 commits into from

Conversation

scottgonzalez
Copy link
Member

Fixes #15023

@jzaefferer
Copy link
Member

Works well with mouse, doesn't work with keyboard. Do we expect the user to add tabindex to the custom handle markup? Or is this a spinner bug?

@jzaefferer
Copy link
Member

To me it seems like a bug - we should also add a test.

@scottgonzalez
Copy link
Member Author

Yeah, we should handle this inside the slider.

@scottgonzalez
Copy link
Member Author

Updated to apply tabIndex to all handles; includes a test.

@jzaefferer
Copy link
Member

Updated diff looks good. Haven't tested it again though.

@scottgonzalez scottgonzalez deleted the slider-demo-handle branch September 13, 2016 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottgonzalez @jzaefferer @jquerybot