Fix #341. #342
Fix #341. #342
Conversation
|
Hey hey! Not sure what the status of this pull request is, and if this is a idiosyncratic way of fixing it, but it fixed my problem with building in platformio on a wemos mini d1 pro. So thanks @me21, and it would be great if it can be merged! |
|
@couchninja Looks like this patch will break other, non-ESP implementations. It will likely not be merged and some other patch will need to be prepared. |
|
Hey @me21 the fix you posted in the issue works for me on the esp platform and as you've added an ifdef it looks like a good fix. Is there a reason you haven't created a PR for it? I'm happy to submit it and reference your fix. |
|
@piratebriggs I've forgotten already what ifdef I've added, but please go ahead with PR :) |
Signed-off-by: Alexandr Zarubkin <[email protected]>
|
@jrowberg @piratebriggs I've updated my PR, it builds for me, can you take a look please? |
No description provided.