-
Notifications
You must be signed in to change notification settings - Fork 129
Added logout button #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rats! Forgot to put in the tests. Added in this latest push. |
Great work! 🎉 Travis errors because of Since tests run in Would you mind updating node_js:
- '8'
- - '7'
- - '6' |
app/components/LoggedIn.js
Outdated
}); | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the additional newline?
app/containers/LoggedInPage.js
Outdated
|
||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot. Btw I've been using prettier
for a while now and we never ever had to bother about code style again. May make sense to plug-in prettier
and add yarn format
to re-format all the code, that also removes trailing newlines etc..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah definitely agreed! I use prettier
in all my projects now. I think it's definitely worthwhile to add.
Sorry about the blank lines...I have been using Beautify (but it is manual) and am looking at prettier now. I have it installed in VSCode and in the project as a part of the pre-commit. However, in VSCode it is messing up with JSX. Check out how it formatted the render: render() { Which of the 10 million Prettier plug-ins are you using? I haven't looked at the pre-commit to see if that is working yet. |
I use prettier from terminal to be fair, i.e:
then run as
My current config
|
Crap! Nevermind....Beautify was still active and they were conflicting......ok.....I will get a new commit here shortly. |
@BlackConure don't worry about adding prettier in this PR. We've opened up an issue which we'll track separately: #56 Just remove the lines manually and update the travis config per pronebirds suggestion and we're all set! |
What @jschr said, no point to bother with the exact style, we'll reformat everything later. |
Ok will do...few mins. |
Sorry....looks like prettier default was double quotes and now I just found another place it needs to be corrected. Re-submitting. |
FYI...if you are using VSCode, you might want to look at the add-in Prettier Now instead of Esben Petersen's version. It seems to be better about JSX, and it also didn't break long lines (nor put double quotes in as a default). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🎉
Yeah, prettier uses double quote in JSX and I think I read that JSX has some issues with single quotes and that it's impossible to escape |
Thanks @BlackConure! |
Simple update to the boilerplate which allows returning back to the main page after a login name has been locally stored.