Skip to content

Add prettier #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 13, 2018
Merged

Add prettier #58

merged 5 commits into from
Jul 13, 2018

Conversation

pronebird
Copy link
Collaborator

@pronebird pronebird commented Jul 12, 2018

Closes #56

.prettierrc.yml is subjective, that's what we use in Mullvad VPN. .editorconfig is respected by many editors and prettier itself so we also moved some of the settings from .prettierrc.yml to .editorconfig instead. (such as indentation)

Feel free to give suggestions on formatting etc..

@pronebird pronebird requested a review from jschr July 12, 2018 15:07
@jschr jschr merged commit de6ef31 into jschr:master Jul 13, 2018
@jschr
Copy link
Owner

jschr commented Jul 13, 2018

This is great! I use similar prettier settings so all looks good to me.

Thanks for this.

@pronebird pronebird deleted the add-prettier branch July 14, 2018 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants