PrimaryResourceType not to be null at this point

[sasa-vasiljevic]

SUMMARY

I tried to make very basic working sample of JSONAPI rest service. I followed instructions in building sample. I can run the sample and it shows swagger documentation. However when I try to call a method get on my controller (using Postman, or Swagger) I get following error:

System.InvalidOperationException: Expected IJsonApiRequest.PrimaryResourceType not to be null at this point.
   at JsonApiDotNetCore.Services.JsonApiResourceService`2.GetAsync(CancellationToken cancellationToken) in C:\projects\jsonapidotnetcore\src\JsonApiDotNetCore\Services\JsonApiResourceService.cs:line 63

DETAILS

I have a Reastaurant object like this:

[Resource]
public class Restaurant : Identifiable<int>
{
    public Restaurant() { }

    [Attr(PublicName = "name")]
    public string? Name { get; set; }

    [Attr(PublicName = "address")]
    public string? Address { get; set; }

    [HasMany(PublicName = "dishes")]
    public virtual List<Dish>? Dishes { get; set; }
}

I have Dish object as this:

[Resource]
public class Dish : Identifiable<int>
{
    public Dish() { }

    [Attr(PublicName = "name")]
    public string? Name { get; set; }

    [Attr(PublicName = "rating")]
    public int? Rating { get; set; }


    [HasOne(PublicName = "restaurant")]
    public virtual Restaurant? Restaurant { get; set; }
    public int RestaurantId { get; set; }
}

My restaurant controller looks like this:

[Route("[controller]")]
public partial class RestaurantsController : JsonApiController<Restaurant, int>
{
    [ActivatorUtilitiesConstructor]
    public RestaurantsController(
        IJsonApiOptions options,
        IResourceGraph resourceGraph,
        IResourceService<Restaurant, int> resourceService,
        ILoggerFactory loggerFactory)
        : base(options, resourceGraph, loggerFactory, resourceService)
    { }
}

and Dish controller same.
That is it. Plus this is startup code:

var builder = WebApplication.CreateBuilder(args);

// Add services to the container.

builder.Services.AddControllers();
builder.Services.AddEndpointsApiExplorer();
builder.Services.AddSwaggerGen();


builder.Services.AddDbContext<AppDbContext>(opt =>
{
    opt.UseSqlServer(builder.Configuration.GetConnectionString("DefaultConnection"));
});
builder.Services.AddJsonApi<AppDbContext>();

var app = builder.Build();

// Configure the HTTP request pipeline.
if (app.Environment.IsDevelopment())
{
    app.UseSwagger();
    app.UseSwaggerUI();
}

app.UseHttpsRedirection();

app.MapControllers();

using (var serviceScope = app.Services.CreateScope())
{
    var context = serviceScope.ServiceProvider.GetService<AppDbContext>();

    context?.Database.EnsureCreated();
    if (context?.Restaurants.Any() == false)
    {
        //...fill database
        context.SaveChanges();
    }
}
app.UseRouting();
app.UseJsonApi();
app.UseEndpoints(endpoints => endpoints.MapControllers());
app.Run();

VERSIONS USED

• JsonApiDotNetCore version: 5.2.0
• ASP.NET Core version: 6.0
• Entity Framework Core version: 7.0.8
• Database provider: MicrosoftSqlServer

[bkoelman]

The stable version of JsonApiDotNetCore does not work with Swagger/OpenAPI. Did you try this on the openapi branch? See also #1046 and https://www.jsonapi.net/getting-started/faq.html#why-cant-i-use-openapi.

[sasa-vasiljevic]

I completely removed Swagger/OpenAPI from application. Still the same error. Here is my startup code now:

            var builder = WebApplication.CreateBuilder(args);

            builder.Services.AddControllers();
            builder.Services.AddDbContext<AppDbContext>(opt =>
            {
                opt.UseSqlServer(builder.Configuration.GetConnectionString("DefaultConnection"));
            });
            builder.Services.AddJsonApi<AppDbContext>();

            var app = builder.Build();

            // Configure the HTTP request pipeline.

            app.UseHttpsRedirection();

            app.MapControllers();

            app.UseRouting();
            app.UseAuthorization();


            app.UseJsonApi();
            app.UseEndpoints(endpoints => endpoints.MapControllers());


            app.Run();

Controllers and model are the same.

[bkoelman]

I got your sample code working after I removed the following line:

app.MapControllers();

The bare minimum is described at: https://www.jsonapi.net/getting-started/step-by-step.html#add-services-and-middleware.

If you then get an error about multiple controllers found, make sure that your RestaurantsController is in exactly the same namespace as the auto-generated one. You can remove the [Route("[controller]")] line.

Also, you can leave out the PublicName = "..." parameters, the casing convention is automatically applied.

[sasa-vasiljevic]

Thank you. It's working now 😊

…

On Sat, Jun 24, 2023 at 1:23 AM Bart Koelman ***@***.***> wrote: I got your sample code working after I removed the following line: app.MapControllers(); The bare minimum is described at: https://www.jsonapi.net/getting-started/step-by-step.html#add-services-and-middleware . If you then get an error about multiple controllers found, make sure that your RestaurantsController is in exactly the same namespace as the auto-generated one. You can remove the [Route("[controller]")] line. Also, you can leave out the PublicName = "..." entries, the casing convention is automatically applied. — Reply to this email directly, view it on GitHub <#1285 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A6PQNL67EHV6AG7BZ56JVE3XMYQPXANCNFSM6AAAAAAZRSO6SI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- *The content of this email is confidential and intended for the recipient specified in message only. It is strictly forbidden to share any part of this message with any third party, without a written consent of the sender. If you received this message by mistake, please reply to this message and follow with its deletion, so that we can ensure such a mistake does not occur in the future. Any quotations sent are only to be used to compare available offers and do not imply entering into a legally binding agreement unless sent explicitly in the form of a legally binding contract.*