-
-
Notifications
You must be signed in to change notification settings - Fork 158
Performance: Use Span<T> when parsing #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
crfloyd
pushed a commit
to crfloyd/JsonApiDotNetCore
that referenced
this issue
Apr 24, 2018
… string as Span<char> given a char delimeter. Language version updated to 7.2 due to need for ref Struct to utilize Span<T> as a field.
crfloyd
pushed a commit
to crfloyd/JsonApiDotNetCore
that referenced
this issue
Apr 24, 2018
…estMiddleware, JsonApiContext, and QueryParser to utilize new SpanSplitter library to avoid unnecessary intermediate string creation.
crfloyd
pushed a commit
to crfloyd/JsonApiDotNetCore
that referenced
this issue
Apr 24, 2018
…'s logic. ContentNegotion tests pass.
crfloyd
added a commit
to crfloyd/JsonApiDotNetCore
that referenced
this issue
Apr 25, 2018
…ming to be more accurate
crfloyd
added a commit
to crfloyd/JsonApiDotNetCore
that referenced
this issue
Apr 25, 2018
…pdates usages and unit tests to use extension method.
jaredcnance
added a commit
that referenced
this issue
May 6, 2018
jaredcnance
pushed a commit
that referenced
this issue
Aug 12, 2018
…<char> given a char delimeter. Language version updated to 7.2 due to need for ref Struct to utilize Span<T> as a field.
jaredcnance
pushed a commit
that referenced
this issue
Aug 12, 2018
…JsonApiContext, and QueryParser to utilize new SpanSplitter library to avoid unnecessary intermediate string creation.
jaredcnance
pushed a commit
that referenced
this issue
Aug 12, 2018
jaredcnance
pushed a commit
that referenced
this issue
Aug 12, 2018
…nd unit tests to use extension method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Split
is going to allocate at least 2 additional string, and in these cases we should be able to just useSpan<T>
and allocate only when required.JsonApiDotNetCore/src/JsonApiDotNetCore/Middleware/RequestMiddleware.cs
Lines 55 to 59 in eb2c309
JsonApiDotNetCore/src/JsonApiDotNetCore/Services/QueryParser.cs
Lines 97 to 104 in c2cb69f
JsonApiDotNetCore/src/JsonApiDotNetCore/Builders/LinkBuilder.cs
Lines 23 to 37 in 83d4a1d
JsonApiDotNetCore/src/JsonApiDotNetCore/Internal/Query/RelatedAttrFilterQuery.cs
Lines 18 to 20 in c2cb69f
JsonApiDotNetCore/src/JsonApiDotNetCore/Services/JsonApiContext.cs
Line 67 in c2cb69f
The text was updated successfully, but these errors were encountered: