Skip to content

Intermittent Test Failure #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jaredcnance opened this issue Jul 10, 2018 · 0 comments
Closed

Intermittent Test Failure #337

jaredcnance opened this issue Jul 10, 2018 · 0 comments
Labels
bug

Comments

@jaredcnance
Copy link
Contributor 

[xUnit.net 00:00:01.5243554]     UnitTests.DocumentBuilder_Tests.Build_Will_Use_Instance_Specific_Resource_If_Defined_For_Multiple_Documents [FAIL]
Failed   UnitTests.DocumentBuilder_Tests.Build_Will_Use_Instance_Specific_Resource_If_Defined_For_Multiple_Documents
Error Message:
 System.NullReferenceException : Object reference not set to an instance of an object.
Stack Trace:
   at JsonApiDotNetCore.Models.ResourceDefinition`1.Remove(Expression`1 filter, List`1 from) in /home/travis/build/json-api-dotnet/JsonApiDotNetCore/src/JsonApiDotNetCore/Models/ResourceDefinition.cs:line 53
   at UnitTests.DocumentBuilder_Tests.InstanceSpecificUserResource.OutputAttrs(User instance) in /home/travis/build/json-api-dotnet/JsonApiDotNetCore/test/UnitTests/Builders/DocumentBuilder_Tests.cs:line 366
   at JsonApiDotNetCore.Models.ResourceDefinition`1.GetOutputAttrs(Object instance) in /home/travis/build/json-api-dotnet/JsonApiDotNetCore/src/JsonApiDotNetCore/Models/ResourceDefinition.cs:line 89
   at JsonApiDotNetCore.Builders.DocumentBuilder.GetData(ContextEntity contextEntity, IIdentifiable entity, IResourceDefinition resourceDefinition) in /home/travis/build/json-api-dotnet/JsonApiDotNetCore/src/JsonApiDotNetCore/Builders/DocumentBuilder.cs:line 126
   at JsonApiDotNetCore.Builders.DocumentBuilder.Build(IEnumerable`1 entities) in /home/travis/build/json-api-dotnet/JsonApiDotNetCore/src/JsonApiDotNetCore/Builders/DocumentBuilder.cs:line 70
   at UnitTests.DocumentBuilder_Tests.Build_Will_Use_Instance_Specific_Resource_If_Defined_For_Multiple_Documents() in /home/travis/build/json-api-dotnet/JsonApiDotNetCore/test/UnitTests/Builders/DocumentBuilder_Tests.cs:line 328
jaredcnance added a commit that referenced this issue Jul 10, 2018
@jaredcnance
fix(#337): run tests serially
fa2ab90 
this is because we made the ContextGraph a static instance...if C# ever supports interfaced statics, we could swap the IContextGraph source when the test assembly starts executing
@jaredcnance jaredcnance mentioned this issue Jul 10, 2018
Merged
jaredcnance added a commit that referenced this issue Jul 10, 2018
@jaredcnance
Merge pull request #338 from json-api-dotnet/fix/#337-serial-test-exe…
404231b 
…cution

fix(#337): run tests serially
jaredcnance added a commit that referenced this issue Aug 12, 2018
@jaredcnance
fix(#337): run tests serially
68802bb 
this is because we made the ContextGraph a static instance...if C# ever supports interfaced statics, we could swap the IContextGraph source when the test assembly starts executing
jaredcnance added a commit that referenced this issue Aug 12, 2018
@jaredcnance
Merge pull request #338 from json-api-dotnet/fix/#337-serial-test-exe…
1354761 
…cution

fix(#337): run tests serially
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaredcnance