Skip to content

Null valued attributes are not omitted from included data #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ddaspit opened this issue Dec 6, 2018 · 2 comments · Fixed by #461
Closed

Null valued attributes are not omitted from included data #454

ddaspit opened this issue Dec 6, 2018 · 2 comments · Fixed by #461
Labels
bug

Comments

@ddaspit
Copy link

ddaspit commented Dec 6, 2018 •
edited
Loading

Description

If DocumentBuilderOptions.OmitNullValuedAttributes is set to true and an included resource object has a null valued attribute, it will not be omitted. Any null valued attributes in primary resource objects are correctly omitted. It looks like DocumentBuilder.GetIncludedEntity() does not check OmitNullValuedAttribute() method when adding attributes.

Environment

  • JsonApiDotNetCore Version: 3.0
  • Other Relevant Package Versions:
@jaredcnance jaredcnance added the bug label Dec 6, 2018
@milosloub milosloub mentioned this issue Dec 9, 2018
Merged
@milosloub
Copy link
Contributor

I'll prepare fix for this within following days

@milosloub milosloub mentioned this issue Dec 15, 2018
Merged
milosloub added a commit that referenced this issue Dec 18, 2018
@milosloub
Merge pull request #461 from json-api-dotnet/fix/#454
2a8a02f 
Omit null attributes in included array
@ddaspit
Copy link
Author

ddaspit commented Jan 8, 2019

Thank you for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Omit null attributes in included array json-api-dotnet/JsonApiDotNetCore
3 participants
@ddaspit @jaredcnance @milosloub