Skip to content

Removing dependency on JsonApiDotNetCoreExample project in test projects #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

maurei
Copy link
Member

@maurei maurei commented Sep 2, 2021

Closes #1031

Also required for introducing a OpenAPI testing environment in #1047.

@maurei maurei marked this pull request as ready for review September 2, 2021 09:51
@maurei maurei changed the title Simplifying BaseIntegrationTestContext Removing test project dependency on JsonApiDotNetCoreExample project Sep 2, 2021
@maurei maurei changed the title Removing test project dependency on JsonApiDotNetCoreExample project Removing dependency on JsonApiDotNetCoreExample project in integration tests Sep 2, 2021
@maurei maurei changed the title Removing dependency on JsonApiDotNetCoreExample project in integration tests Removing dependency on JsonApiDotNetCoreExample project in test projects Sep 2, 2021
@maurei maurei requested a review from bart-degreed September 2, 2021 10:31
@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #1068 (4a38b27) into master (a8a0bf0) will decrease coverage by 1.46%.
The diff coverage is n/a.

❗ Current head 4a38b27 differs from pull request most recent head 19a3c51. Consider uploading reports for the commit 19a3c51 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1068      +/-   ##
==========================================
- Coverage   89.95%   88.48%   -1.47%     
==========================================
  Files         257      256       -1     
  Lines        7026     7024       -2     
==========================================
- Hits         6320     6215     -105     
- Misses        706      809     +103     
Impacted Files Coverage Δ
...mples/JsonApiDotNetCoreExample/Startups/Startup.cs 0.00% <ø> (-95.84%) ⬇️
...ples/JsonApiDotNetCoreExample/Data/AppDbContext.cs 0.00% <0.00%> (-100.00%) ⬇️
...NetCoreExample/Controllers/NonJsonApiController.cs 0.00% <0.00%> (-100.00%) ⬇️
...NetCoreExample/Controllers/OperationsController.cs 0.00% <0.00%> (-100.00%) ⬇️
src/Examples/JsonApiDotNetCoreExample/Program.cs 0.00% <0.00%> (-66.67%) ⬇️
...iDotNetCore/Diagnostics/DefaultCodeTimerSession.cs 0.00% <0.00%> (-60.00%) ⬇️
...sonApiDotNetCore/Diagnostics/CascadingCodeTimer.cs 0.00% <0.00%> (-10.19%) ⬇️
...DotNetCore/Configuration/ServiceDiscoveryFacade.cs 97.93% <0.00%> (-2.07%) ⬇️
...piDotNetCore/Configuration/ResourceGraphBuilder.cs 97.56% <0.00%> (-1.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06becc9...19a3c51. Read the comment docs.

@maurei maurei force-pushed the simplifying-test-contexts branch from 9c4c805 to a2d6dbc Compare September 2, 2021 12:53
@maurei maurei force-pushed the simplifying-test-contexts branch from aaa40ac to 19a3c51 Compare September 3, 2021 14:15
@bart-degreed bart-degreed merged commit 523ac62 into master Sep 3, 2021
@bart-degreed bart-degreed deleted the simplifying-test-contexts branch September 3, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Improved isolation of tests
2 participants