Make it easier to register custom services in the IoC container #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes app setup easier. Previously, you often had to register overrides *after* calling AddJsonApi (last one wins). With this change, order does not matter anymore. Note that the order of MVC filters still matters, it is unrelated to this change.
Codecov Report
@@ Coverage Diff @@
## master #1352 +/- ##
=======================================
Coverage 93.02% 93.02%
=======================================
Files 268 268
Lines 8802 8802
=======================================
Hits 8188 8188
Misses 614 614
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes app setup easier. Previously, you often had to register overrides after calling
AddJsonApi(last one wins). With this change, order does not matter anymore. Note that the order of MVC filters still matters, it is unrelated to this change.Samples have been updated to register before calling
AddJsonApi, because that works now. And in integration tests, theConfigureServicesBeforeStartup/ConfigureServicesAfterStartupmethods have been collapsed into one.Enumerable services are a bit more complicated, so I've added tests for that.
Closes #1347
QUALITY CHECKLIST