- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 158
openapi: support client-generated id #1475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openapi: support client-generated id #1475
Conversation
@bkoelman could you help with the those comments 👆 |
Tests are needed to cover:
for the three modes The easiest setup would be to have three resource types with different |
441ef62
to
5cabf90
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## openapi #1475 +/- ##
========================================
Coverage 90.75% 90.75%
========================================
Files 390 390
Lines 12883 12883
Branches 2044 2044
========================================
Hits 11692 11692
Misses 776 776
Partials 415 415 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
test/OpenApiTests/ClientIdGenerationModes/ClientGeneratedIdFakers.cs
Outdated
Show resolved
Hide resolved
test/OpenApiTests/ClientIdGenerationModes/ClientGeneratedIdFakers.cs
Outdated
Show resolved
Hide resolved
test/OpenApiTests/ClientIdGenerationModes/ClientGeneratedIdTests.cs
Outdated
Show resolved
Hide resolved
test/OpenApiTests/ClientIdGenerationModes/ClientGeneratedIdTests.cs
Outdated
Show resolved
Hide resolved
test/OpenApiTests/ClientIdGenerationModes/ClientGeneratedIdTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor comments.
test/OpenApiEndToEndTests/ClientIdGenerationModes/ClientIdGenerationModesTests.cs
Outdated
Show resolved
Hide resolved
test/OpenApiEndToEndTests/ClientIdGenerationModes/ClientIdGenerationModesTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If you don't mind, I'd like to merge Kiota support first, so Kiota tests can be added to this PR before merging it.
bf41287
to
66cf92f
Compare
66cf92f
to
fccd8dd
Compare
fccd8dd
to
54c401c
Compare
Thanks! I couldn't find the time to do the Kiota part. |
Closes #1054
QUALITY CHECKLIST