Skip to content

openapi: support client-generated id #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

verdie-g
Copy link
Contributor

@verdie-g verdie-g commented Feb 23, 2024

Closes #1054

QUALITY CHECKLIST

@verdie-g
Copy link
Contributor Author

@bkoelman could you help with the those comments 👆

@bkoelman
Copy link
Member

Tests are needed to cover:

  • Sending without ID
  • Sending with ID

for the three modes Forbidden, Allowed and Required.

The easiest setup would be to have three resource types with different [Resource(ClientIdGeneration = ...)] for the three modes.

Verified

This commit was signed with the committer’s verified signature.
dreamorosi Andrea Amorosi

Verified

This commit was signed with the committer’s verified signature.
dreamorosi Andrea Amorosi
@verdie-g verdie-g force-pushed the 1054-client-generated-id branch from 441ef62 to 5cabf90 Compare February 23, 2024 21:35
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (54c401c) to head (8af7556).

Additional details and impacted files
@@           Coverage Diff            @@
##           openapi    #1475   +/-   ##
========================================
  Coverage    90.75%   90.75%           
========================================
  Files          390      390           
  Lines        12883    12883           
  Branches      2044     2044           
========================================
  Hits         11692    11692           
  Misses         776      776           
  Partials       415      415           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@verdie-g verdie-g marked this pull request as ready for review February 23, 2024 21:55
@verdie-g verdie-g requested a review from bkoelman February 23, 2024 21:55
Copy link
Member

@bkoelman bkoelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

Verified

This commit was signed with the committer’s verified signature.
dreamorosi Andrea Amorosi
@verdie-g verdie-g requested a review from bkoelman February 24, 2024 03:21
Copy link
Member

@bkoelman bkoelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

Verified

This commit was signed with the committer’s verified signature.
dreamorosi Andrea Amorosi
@verdie-g verdie-g requested a review from bkoelman February 26, 2024 04:38

Verified

This commit was signed with the committer’s verified signature.
dreamorosi Andrea Amorosi
Copy link
Member

@bkoelman bkoelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments.

Verified

This commit was signed with the committer’s verified signature.
dreamorosi Andrea Amorosi
@verdie-g verdie-g requested a review from bkoelman February 26, 2024 23:23
Copy link
Member

@bkoelman bkoelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If you don't mind, I'd like to merge Kiota support first, so Kiota tests can be added to this PR before merging it.

@bkoelman bkoelman changed the base branch from openapi to openapi-client-generated-ids March 10, 2024 09:44
@bkoelman bkoelman force-pushed the openapi-client-generated-ids branch from bf41287 to 66cf92f Compare March 10, 2024 09:45
@bkoelman bkoelman changed the base branch from openapi-client-generated-ids to openapi March 10, 2024 09:45
@bkoelman bkoelman changed the base branch from openapi to openapi-client-generated-ids March 10, 2024 09:45
@bkoelman bkoelman force-pushed the openapi-client-generated-ids branch from 66cf92f to fccd8dd Compare March 10, 2024 09:48
@bkoelman bkoelman changed the base branch from openapi-client-generated-ids to openapi March 10, 2024 09:48
@bkoelman bkoelman changed the base branch from openapi to openapi-client-generated-ids March 10, 2024 09:49
@bkoelman bkoelman force-pushed the openapi-client-generated-ids branch from fccd8dd to 54c401c Compare March 10, 2024 09:50
@bkoelman bkoelman changed the base branch from openapi-client-generated-ids to openapi March 10, 2024 09:50
@bkoelman bkoelman changed the base branch from openapi to openapi-client-generated-ids March 10, 2024 09:50
@bkoelman bkoelman merged commit a824bd0 into json-api-dotnet:openapi-client-generated-ids Mar 10, 2024
@verdie-g
Copy link
Contributor Author

Thanks! I couldn't find the time to do the Kiota part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants