Merge master into openapi (controller attribute fixes) #1507
+362
−200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… most of the previous PR (#1503). It turns out that ASP.NET ModelState doesn't look at attributes on base parameters
…ed-changes Move back [FromBody] and [Required] to derived controllers
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## openapi #1507 +/- ##
========================================
Coverage 90.79% 90.79%
========================================
Files 394 394
Lines 12957 12957
Branches 2057 2057
========================================
Hits 11764 11764
Misses 777 777
Partials 416 416 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges the master branch into openapi, which makes request bodies in OpenAPI required.
No merge conflicts were reported.
QUALITY CHECKLIST