Basic OpenAPI tests for all JSON:API endpoints #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkoelman
force-pushed
the
openapi-endpoint-tests
branch
from
770a429 to
8f36981
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## openapi #1512 +/- ##
===========================================
- Coverage 90.80% 90.77% -0.03%
===========================================
Files 394 394
Lines 12975 12992 +17
Branches 2057 2057
===========================================
+ Hits 11782 11794 +12
- Misses 777 782 +5
Partials 416 416 ☔ View full report in Codecov by Sentry. |
…he same ID already exists on post resource request
Turns out these were not redundant, after all. They are needed as entry points for request body parameters. A default schema is being generated without them, so not running our own generator. The effect is that 'data' in nullable relationships is not marked as `nullable: true`. This reverts commit b0fa688.
Reverting the effects of this Resharper rule because it makes stack traces harder to understand, while the gain it provides is theoretical. Resharper turned off this suggestion in the default ruleset in a later version. This reverts commit 9919ccc.
bkoelman
force-pushed
the
openapi-endpoint-tests
branch
from
8f36981 to
8556a30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic OpenAPI tests for all JSON:API endpoints, both for NSwag and Kiota.
Additionally, this PR fixes several OpenAPI bugs (links, error status codes) and adds missing tests. See the individual commits for details.
Closes #1243.
QUALITY CHECKLIST