Skip to content

Add support for configuring the visibility of the "describedby" link #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

bkoelman
Copy link
Member

@bkoelman bkoelman commented Mar 23, 2024

This PR enables configuring whether the "describedby" top-level link is rendered, assuming it has a value.
Follow-up of #1495.

Example (global options):

options.TopLevelLinks = LinkTypes.Self | LinkTypes.Related | LinkTypes.DescribedBy | LinkTypes.Pagination;

Example (overruled per resource type):

[Resource]
[ResourceLinks(TopLevelLinks = LinkTypes.Self | LinkTypes.Related | LinkTypes.DescribedBy | LinkTypes.Pagination)]
public sealed class ExampleResource : Identifiable<long>
{
    // ...
}

QUALITY CHECKLIST

@bkoelman bkoelman force-pushed the linktypes-describedby branch from ed33774 to 86ff196 Compare March 23, 2024 16:32
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.79%. Comparing base (2fcfc65) to head (86ff196).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1516   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files         346      346           
  Lines       11062    11063    +1     
  Branches     1813     1814    +1     
=======================================
+ Hits        10044    10045    +1     
  Misses        669      669           
  Partials      349      349           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman marked this pull request as ready for review March 23, 2024 16:50
@bkoelman bkoelman merged commit b39e2cc into master Mar 23, 2024
16 checks passed
@bkoelman bkoelman deleted the linktypes-describedby branch March 23, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant